Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/g3m liquidity exact token #47

Merged
merged 19 commits into from
Oct 19, 2023
Merged

Conversation

clemlak
Copy link
Contributor

@clemlak clemlak commented Oct 18, 2023

Update addLiquidity and removeLiquidity to use an exact amount of token X or Y (previous functions using an exact amount of liquidity were kept).

@clemlak clemlak self-assigned this Oct 18, 2023
Copy link
Contributor

@Alexangelj Alexangelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the rationale for these exact functions? I see us using them in the sim since they reduce some of the external code we need to do (computing both amounts)

@clemlak
Copy link
Contributor Author

clemlak commented Oct 19, 2023

What's the rationale for these exact functions? I see us using them in the sim since they reduce some of the external code we need to do (computing both amounts)

Yes, they are mainly convenience functions, they'll be useful for the sims but could be useful for end users too.

@0xJepsen 0xJepsen self-requested a review October 19, 2023 17:59
@Alexangelj Alexangelj merged commit a6a7cf2 into main Oct 19, 2023
@Alexangelj Alexangelj deleted the feat/g3m-liquidity-exact-token branch October 23, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants