Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust analysis #76

Merged
merged 13 commits into from
Oct 27, 2023
Merged

rust analysis #76

merged 13 commits into from
Oct 27, 2023

Conversation

Autoparallel
Copy link
Contributor

@Autoparallel Autoparallel commented Oct 27, 2023 •
edited
Loading

Lots went on here. Some of this was debugging the parallelization issues.

  • That led to the additional semaphore which caps the maximal amount of concurrent simulations. I made this optional.
  • Added analysis in python.
  • Updated to arbiter-core 0.7.0 and now handle the new data output standard.
  • Started analysis rust crate (will transfer python over iteratively).

@Autoparallel Autoparallel marked this pull request as ready for review October 27, 2023 16:43
kinrezC
kinrezC approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@kinrezC kinrezC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

Alexangelj
Alexangelj approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@Alexangelj Alexangelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks excellent

0xJepsen
0xJepsen approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is clean im excited for the rust analysis.

@Alexangelj Alexangelj mentioned this pull request Oct 27, 2023
Closed
@kinrezC kinrezC merged commit 5f24449 into main Oct 27, 2023
@kinrezC kinrezC deleted the analysis-volatility-targeting branch October 27, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinrezC kinrezC kinrezC approved these changes

@Alexangelj Alexangelj Alexangelj approved these changes

@0xJepsen 0xJepsen 0xJepsen approved these changes

@zachdt zachdt Awaiting requested review from zachdt

@pranavpatilsce pranavpatilsce Awaiting requested review from pranavpatilsce

@clemlak clemlak Awaiting requested review from clemlak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Autoparallel @kinrezC @Alexangelj @0xJepsen