Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/UI components #79

Merged
merged 7 commits into from
Oct 31, 2023
Merged

Feat/UI components #79

merged 7 commits into from
Oct 31, 2023

Conversation

Alexangelj
Copy link
Contributor

Changelog

  • Restructures ui/src/ directory & file structure to be cleaner.
  • Adds an additional "application" argument to the cli, so we can make more than one application now and call it from cli.
  • Moves existing ui stuff to be just examples, i.e. example application and an example component
  • Dedicated sdk directory to put non-iced stuff
  • Adds more documentation to the readme on how to use ui crate and implement things for it.

Yes, you can make your own application with its own components if you'd like!

@Alexangelj
Copy link
Contributor Author

Almost done with this

@Alexangelj Alexangelj marked this pull request as ready for review October 30, 2023 23:01
Copy link
Contributor

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good. I'm going to have to play with it myself to understand how it all stitches together better.

Comment on lines 40 to 45
#[derive(Debug, Clone)]
pub enum ExampleScreenError {
APIError,
ProviderConnectionError,
BlockSubscriptionError,
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a PR that simplifies this a bit.

@@ -0,0 +1,54 @@
# Excalibur Ui
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like how you give us some good resources here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This banner also feels very tasteful

@0xJepsen 0xJepsen merged commit 825bfc0 into main Oct 31, 2023
@Alexangelj Alexangelj deleted the feat/ui-components branch October 31, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants