Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allocate and Swap should be payable #140

Closed
Alexangelj opened this issue Jan 6, 2023 · 0 comments
Closed

Allocate and Swap should be payable #140

Alexangelj opened this issue Jan 6, 2023 · 0 comments
Assignees
@Alexangelj
Labels
minor code change Refactors or fixes critical code with minimal changes.
Milestone
Launch🚀

Comments

@Alexangelj
Copy link
Contributor

Both these functions should support WETH pools via payable.
@0xJepsen 0xJepsen added the minor code change Refactors or fixes critical code with minimal changes. label Jan 20, 2023
@0xJepsen 0xJepsen added this to the Launch🚀 milestone Jan 20, 2023
Alexangelj added a commit that referenced this issue Jan 24, 2023
@Alexangelj
Merge pull request #170 from primitivefinance/fix/payable-functions
d044357 
fix(#140): closes #140 by making allocate and swap payable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alexangelj Alexangelj

Labels
minor code change Refactors or fixes critical code with minimal changes.
Projects
None yet
Milestone
Launch🚀
Development

No branches or pull requests
2 participants
@Alexangelj @0xJepsen