Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use constant for fee denominator #257

Merged
merged 2 commits into from
Mar 9, 2023
Merged

chore: use constant for fee denominator #257

merged 2 commits into from
Mar 9, 2023

Conversation

TomAFrench
Copy link
Contributor

We already have this constant for calculating fees elsewhere so lets use it in Portfolio as well.

@TomAFrench TomAFrench force-pushed the fee-denominator-constant branch from e07a46e to 67d6a67 Compare March 7, 2023 20:11
Alexangelj
Alexangelj approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@Alexangelj Alexangelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for making this change, was bugging me

LGTM

@clemlak clemlak merged commit 0326d5b into primitivefinance:main Mar 9, 2023
@TomAFrench TomAFrench deleted the fee-denominator-constant branch March 9, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexangelj Alexangelj Alexangelj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomAFrench @Alexangelj @clemlak