feat: reduce bytecode by removing unnecessary return values #265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validateParameters
never returns a non-emptyreason
as it will always revert if an error has occurred. It will also only return in the case wheresuccess == true
. We then don't need to spend the bytecode associated with returning(true, "")
as these return values aren't used.This removes ~0.09kB of bytecode (giving us plenty of space for #260).
I also noticed that
changePoolParameters
seems to not be being inlined properly by the compiler. Considering how small the function is you could inline it manually (as you do in_createPool
) however I've removed this inlining for consistency as it's a relatively small change in bytecode size.