refactor(pool-nonce): updates pool nonce to be a mapping from pair nonce #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Must run forge fmt on this pr before merging. This must be done after the it has been run on the main branch with the new formatter settings in the toml. |
Alexangelj
force-pushed
the
refactor/pool-nonce
branch
from
60e6e14 to
7509350
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MUST MERGE
chore/fmtFIRST.Description
getPoolNoncea mapping using the uint24pairNonceas a key.This expands the total amount of pools by a significant amount, since there can be 2^32 pools for all 2^24 pairs. Before, the pool nonce space was global, limiting the sum of all 2^24 pairs to 2^32 total pools.
These types were on the larger side to be conservative about the amount of pools/pairs created. However, with this mapping, we might be able to reconsider the size of both the values. Pairs take 3 bytes, pool nonces take 4 bytes, this could be potentially halved.