Audit/sherlock audit v2

[Alexangelj]

Changelog

• Updates PrimitiveFactory to reference the stableDecimals if the error is thrown for the stableDecimals, rather than passing in the riskyDecimals
• Updates natspec comments on create parameters to be inclusive of sigma boundaries, and outside of min liquidity range
• Updates create's strike argument from a uint256 to a uint128. Removes the downcasting of it.
• Updates the Create event arguments to match respective types
• Gas optimization in SwapDetails struct, and variable packing the unlocked state variable with an immutable address
• Updates natspec on MinLiquidityError, thrown when delLiquidity is less than or equal to MIN_LIQUIDITY

[SherlockProtocol]

Hi @Alexangelj

The report stated in L-05

Besides, as the comment says, the MinLiquidityError error is thrown when the liquidity is lower than the minimum amount of liquidity. However, if delLiquidity equals MIN_LIQUIDITY, a MinLiquidityError error is thrown as well.

This finding doesn't seem to be addressed in this PR @ https://github.com/primitivefinance/primitive-v2-core/blob/audit/sherlock-audit-v2/contracts/PrimitiveEngine.sol#L167

[Alexangelj]

Hi @Alexangelj

The report stated in L-05

Besides, as the comment says, the MinLiquidityError error is thrown when the liquidity is lower than the minimum amount of liquidity. However, if delLiquidity equals MIN_LIQUIDITY, a MinLiquidityError error is thrown as well.

This finding doesn't seem to be addressed in this PR @ https://github.com/primitivefinance/primitive-v2-core/blob/audit/sherlock-audit-v2/contracts/PrimitiveEngine.sol#L167

Ah, I updated the MIN_LIQUIDITY natspec to describe less than or equal to. So the delLiquidity must be greater than min liquidity. Else, it'd be possible to mint 0 zero liquidity on create calls if delLiquidity is equal to the min.

[Alexangelj]

🎉 This PR is included in version 1.12.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀