Feat/v1.0.0 beta #29

Alexangelj · 2023-02-21T21:03:24Z

Description

Minor changes for 1.0.0-beta release.

Adds an absolute error bound to the getX tests.
Removes hardcoded return value of zero in ierfc. The theoretical ierfc(1) returns zero, but the approximation does not. We should match the approximation exactly (gaussian.js).
Switches solidity<>yul implementations. Solidity version is the "production" version and yul is the "reference" version. The yul implementation can be used/improved/audited later. For now, getting a safe and working implementation of this library is a priority.
Updates natspec on the functions with error relative to JS implementation.

@clemlak fix rust differential tests run in the CI (check old ci runs for the error)

… to cli

… error in ierfc

Alexangelj added 9 commits February 21, 2023 12:53

test(ref-getX): fixes getX reference test with approxEqAbs, adds erfc…

04e9eb7

… to cli

fix(ierfc): removes hardcoded zero return value for ierfc(1)

56f6479

feat(solc-0.8.4): unlocks pragmas from 0.8.4 onwards

ac1bc08

build(pkg): package json version bumped to v1.0.0-beta

6255e89

test(error-amt): updates epsilon in differential tests

f272c08

refactor(use-sol): uses solidity over yul for readability... for now

9d92706

test(temp-fix): comments rust diff tests, fix for ci later

ba264be

fix(dead-error): removes unused OverFlow error, uses NegativeInfinity…

17aac69

… error in ierfc

fix(test-ierfc): updates expected revert to negativeinfinity in ierfc

8bfadaf

Alexangelj marked this pull request as ready for review February 24, 2023 00:06

Alexangelj mentioned this pull request Feb 24, 2023

Erfc Fails to be monotonically decreasing #15

Closed

Alexangelj merged commit 11818da into main Feb 24, 2023

Alexangelj deleted the feat/v1.0.0-beta branch March 30, 2023 22:15