Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 385 - Update scene view in global_flat_shading() #386

Closed
wants to merge 2 commits into from

Conversation

hdoi5324
Copy link
Contributor

@hdoi5324 hdoi5324 commented Dec 5, 2024

blendergt task crashes at globat_flat_shading(). See issue 385

Updating the scene after removing 'Atmosphere' and 'Atmosphere Fine' objects seems to fix it. Add bpy.context.view_layer.update() after removing these objects

Also remove 'liquid' and 'liquid_fine' for global_flat_shading.

@hdoi5324 hdoi5324 requested a review from araistrick as a code owner December 5, 2024 05:00
@araistrick
Copy link
Collaborator

I am testing this and may tweak / merge it. thanks for the contribution and sorry for being slow in getting to it

FYI I will most likely keep liquid included in ground truth by default, but I will maybe make your liquid change into a gin-configurable kwarg. in future we should probably have a rich config system for this, because it is unclear whether glass / liquids etc should be included in depthmaps.

@araistrick
Copy link
Collaborator

I have cherrypicked 6ca2528 to be included in my v1.12.1 patch. I will close this PR once that is merged, and we consider the liquid-in-groundtruth to be a separate issue if you want to reopen it / file another PR.

thanks for the contribution(s)! i will get to the others asap, likely after the holidays.

@araistrick
Copy link
Collaborator

araistrick commented Dec 24, 2024

Included your GT fix as part of 1.12.1. thanks again. I will credit you in the github release for this verison which will be created ~Dec26

@araistrick araistrick closed this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants