Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: no fatal when building tsc program #994

Merged
merged 1 commit into from
Jun 9, 2020
Merged

refactor: no fatal when building tsc program #994

merged 1 commit into from
Jun 9, 2020

Conversation

jasonkuhrt
Copy link
Member

No description provided.

@jasonkuhrt jasonkuhrt added the type/refactor Address tech debt, internal incidental complexity label Jun 8, 2020
@jasonkuhrt jasonkuhrt requested a review from Weakky June 8, 2020 03:42
Weakky
Weakky approved these changes Jun 9, 2020
View reviewed changes
Copy link
Collaborator

@Weakky Weakky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how we're slowly removing all fatals from the lib!

@jasonkuhrt jasonkuhrt merged commit 15ab57a into master Jun 9, 2020
@jasonkuhrt jasonkuhrt deleted the refactor/no-fatal-when-building-tsc-program branch June 9, 2020 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Weakky Weakky Weakky approved these changes

Assignees
No one assigned
Labels
type/refactor Address tech debt, internal incidental complexity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonkuhrt @Weakky