-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add user agent to posthog #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request bumps versions from 1.1.2 to 1.1.3 across three packages (create-db, create-pg, create-postgres) and replaces the analytics "has-user-agent" boolean property with a "user-agent" string property that reports the actual user agent value. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Pre-merge checks✅ Passed checks (3 passed)
Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
claim-db-worker | 3b3d567 | Commit Preview URL Branch Preview URL |
Dec 14 2025, 10:31 PM |
|
✅ Preview CLIs & Workers are live! Test the CLIs locally under tag npx create-db@pr72
npx create-pg@pr72
npx create-postgres@pr72Worker URLs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
create-db/src/index.ts (1)
361-361: Hardcoded CLI version is inconsistent with package.json.The CLI version is hardcoded as
"1.1.0"whilepackage.jsonshows"1.1.3". This creates confusion for users checking the CLI version.Consider dynamically reading the version from package.json:
import { createRequire } from 'module'; const require = createRequire(import.meta.url); const { version } = require('../package.json');Then use
versioninstead of the hardcoded string:export function createDbCli() { return createCli({ router, name: getCommandName(), - version: "1.1.0", + version: version, description: "Instantly create a temporary Prisma Postgres database", }); }Or at minimum, update the hardcoded value to match the current package version:
- version: "1.1.0", + version: "1.1.3",
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
create-db/package.json(1 hunks)create-db/src/index.ts(1 hunks)create-pg/package.json(1 hunks)create-postgres/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Workers Builds: create-db-worker
- GitHub Check: Workers Builds: claim-db-worker
🔇 Additional comments (4)
create-pg/package.json (1)
3-3: LGTM!Version bump is consistent with the PR's analytics enhancement.
create-postgres/package.json (1)
3-3: LGTM!Version bump is consistent with the PR's analytics enhancement.
create-db/package.json (1)
3-3: LGTM!Version bump is consistent with the PR's analytics enhancement.
create-db/src/index.ts (1)
147-147: Verify no other references to the old field name exist.The old
"has-user-agent"field name is not referenced elsewhere in the codebase. The migration to the new"user-agent"field is complete.
Summary by CodeRabbit
Chores
Updates
✏️ Tip: You can customize this high-level summary in your review settings.