Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating AWS Lambda Serverless Framework guide #5096

Merged
merged 30 commits into from
Aug 18, 2023
Merged

Conversation

jharrell
Copy link
Member

@jharrell jharrell commented Jul 24, 2023

Resolves #5087

This is a PR that has two major changes:

  1. restructure our guides to take advantage of "subsections" to have an automatically generated list of guides

  2. attempt to clean up and revamp our serverless framework guide.

@vercel
Copy link

vercel bot commented Jul 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2023 2:39pm

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023

This PR changes the following pages (Vercel Preview Deploy links):

Changed Vercel links

(Note that links will only be valid after Vercel preview deploy succeeded)

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023

This PR probably requires the following redirects to be added to vercel.json:

  {
    "source": "/docs/guides/deployment/use-prisma-with-serverless-framework",
    "destination": "/docs/##( TODO: Path of page that replaces deleted page )##"
  },

vercel.json Outdated Show resolved Hide resolved
Copy link
Contributor

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this PR just removes our "Deploy to AWS Lambda" guide and replaces it with our Serverless Framework specific considerations (while keeping the URL the same). Is that intentional?

If so, what is the higher level strategy this is following?

@jharrell
Copy link
Member Author

The goal with the deployment guides is to show how to get a baseline project to a deployment environment. For many deployment options (Vercel, Netlify, Heroku, etc) that means a generic app that uses Prisma. AWS Lambda is a bit unique because there's Serverless Framework and SST which are tied really closely to the deployment location. In the future a "AWS Lambda" section with Serverless, SST, and plain lambda code would be great.

Our existing guides were called "deploy to AWS Lambda" but heavily focused on Serverless and the example starter app was a Serverless Framework project. So the title was misleading.

@jharrell jharrell requested a review from janpio July 26, 2023 23:10
@jharrell jharrell changed the title Jharrell/issue5087 Updating AWS Lambda Serverless Framework guide Jul 27, 2023
@jharrell jharrell mentioned this pull request Aug 3, 2023
jharrell and others added 2 commits August 17, 2023 14:02
Co-authored-by: Alex Ruheni <33921841+ruheni@users.noreply.github.com>
Copy link
Contributor

@ruheni ruheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good already. Left a few minor comments that are more of nits.

Co-authored-by: Alex Ruheni <33921841+ruheni@users.noreply.github.com>
@jharrell jharrell merged commit 56b8eea into main Aug 18, 2023
5 checks passed
@jharrell jharrell deleted the jharrell/issue5087 branch August 18, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update deployment guide for AWS Lambda (Serverless Framework)
4 participants