-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating AWS Lambda Serverless Framework guide #5096
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This PR changes the following pages (Vercel Preview Deploy links): Changed Vercel links
(Note that links will only be valid after Vercel preview deploy succeeded) |
This PR probably requires the following redirects to be added to vercel.json:
|
content/300-guides/200-deployment/110-deployment-guides/001-deploying-to-aws-lambda.mdx
Outdated
Show resolved
Hide resolved
content/300-guides/200-deployment/110-deployment-guides/001-deploying-to-aws-lambda.mdx
Outdated
Show resolved
Hide resolved
content/300-guides/200-deployment/110-deployment-guides/001-deploying-to-aws-lambda.mdx
Outdated
Show resolved
Hide resolved
content/300-guides/200-deployment/110-deployment-guides/001-deploying-to-aws-lambda.mdx
Outdated
Show resolved
Hide resolved
content/300-guides/200-deployment/110-deployment-guides/001-deploying-to-aws-lambda.mdx
Outdated
Show resolved
Hide resolved
content/300-guides/200-deployment/110-deployment-guides/index.mdx
Outdated
Show resolved
Hide resolved
content/300-guides/200-deployment/110-deployment-guides/index.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this PR just removes our "Deploy to AWS Lambda" guide and replaces it with our Serverless Framework specific considerations (while keeping the URL the same). Is that intentional?
If so, what is the higher level strategy this is following?
The goal with the deployment guides is to show how to get a baseline project to a deployment environment. For many deployment options (Vercel, Netlify, Heroku, etc) that means a generic app that uses Prisma. AWS Lambda is a bit unique because there's Serverless Framework and SST which are tied really closely to the deployment location. In the future a "AWS Lambda" section with Serverless, SST, and plain lambda code would be great. Our existing guides were called "deploy to AWS Lambda" but heavily focused on Serverless and the example starter app was a Serverless Framework project. So the title was misleading. |
05bc738
to
9591716
Compare
Changes addressed and requesting a re-review
content/300-guides/200-deployment/201-serverless/400-deploy-to-aws-lambda.mdx
Outdated
Show resolved
Hide resolved
content/300-guides/200-deployment/201-serverless/400-deploy-to-aws-lambda.mdx
Outdated
Show resolved
Hide resolved
content/300-guides/200-deployment/201-serverless/400-deploy-to-aws-lambda.mdx
Outdated
Show resolved
Hide resolved
content/300-guides/200-deployment/201-serverless/400-deploy-to-aws-lambda.mdx
Outdated
Show resolved
Hide resolved
content/300-guides/200-deployment/201-serverless/400-deploy-to-aws-lambda.mdx
Outdated
Show resolved
Hide resolved
content/300-guides/200-deployment/201-serverless/400-deploy-to-aws-lambda.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Ruheni <33921841+ruheni@users.noreply.github.com>
content/300-guides/200-deployment/201-serverless/400-deploy-to-aws-lambda.mdx
Show resolved
Hide resolved
content/300-guides/200-deployment/201-serverless/400-deploy-to-aws-lambda.mdx
Outdated
Show resolved
Hide resolved
content/300-guides/200-deployment/201-serverless/400-deploy-to-aws-lambda.mdx
Outdated
Show resolved
Hide resolved
content/300-guides/200-deployment/201-serverless/400-deploy-to-aws-lambda.mdx
Outdated
Show resolved
Hide resolved
content/300-guides/200-deployment/201-serverless/400-deploy-to-aws-lambda.mdx
Outdated
Show resolved
Hide resolved
content/300-guides/200-deployment/201-serverless/400-deploy-to-aws-lambda.mdx
Outdated
Show resolved
Hide resolved
content/300-guides/200-deployment/201-serverless/400-deploy-to-aws-lambda.mdx
Outdated
Show resolved
Hide resolved
content/300-guides/200-deployment/201-serverless/400-deploy-to-aws-lambda.mdx
Outdated
Show resolved
Hide resolved
content/300-guides/200-deployment/201-serverless/400-deploy-to-aws-lambda.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good already. Left a few minor comments that are more of nits.
Co-authored-by: Alex Ruheni <33921841+ruheni@users.noreply.github.com>
Resolves #5087
This is a PR that has two major changes:
restructure our guides to take advantage of "subsections" to have an automatically generated list of guides
attempt to clean up and revamp our serverless framework guide.