-
Notifications
You must be signed in to change notification settings - Fork 856
fix: DC-4710 code color #7056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DC-4710 code color #7056
Conversation
WalkthroughCSS styles were updated to adjust the appearance of inline code elements and code blocks. Inline code within tables and general inline code now uses a secondary font color and a specific background color. Additionally, a margin was added below code block content for improved vertical spacing. Changes
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Dangerous URL checkNo absolute URLs to prisma.io/docs found. |
Redirect checkThis PR probably requires the following redirects to be added to static/_redirects:
|
Deploying docs with
|
| Latest commit: |
647606e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6e459db8.docs-51g.pages.dev |
| Branch Preview URL: | https://fix-dc-4710-table-code-color.docs-51g.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
src/css/custom.css(2 hunks)src/theme/CodeBlock/Content/styles.module.scss(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Check internal links
- GitHub Check: runner / linkspector
- GitHub Check: Lost Pixel
- GitHub Check: Cloudflare Pages
🔇 Additional comments (3)
src/theme/CodeBlock/Content/styles.module.scss (1)
6-6: Check downstream spacing before mergingAdding
margin-bottom: 1emintroduces vertical spacing that never existed on.codeBlockContent.
If any consumer component already pads the surrounding container (e.g. Markdown renderers that append<pre>margins), this extra margin can create double-spacing.Please eyeball a few pages (especially nested tab panels & collapsible blocks) to ensure the new gap doesn’t break layout or scroll-snap calculations.
src/css/custom.css (2)
433-435: Ensure custom palette variables are defined for all themes
table codenow relies on two new CSS custom properties:var(--secondary-font-color) var(--code-inline-bgd-color)If either variable is missing in light / dark theme roots, inline code inside tables will inherit the browser fallback (usually black / transparent) and may lose contrast.
Double-check
:rootstylesheets for both colour schemes before releasing.
1570-1572: Potential contrast issue on anchor code
.anchor codenow usesvar(--primary-font-color)againstvar(--code-inline-bgd-color).
Verify that this combination meets WCAG AA contrast for both light and dark themes; anchor links often sit inside low-contrast headings.If contrast is marginal, bump either the foreground or background shade.
* Update code bg/color in content * Fix more bg and color
Fixes #DC-4710
Summary by CodeRabbit