-
Notifications
You must be signed in to change notification settings - Fork 852
DC-5560 Deno Deploy Integration Guide #7157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Dangerous URL checkNo absolute URLs to prisma.io/docs found. |
WalkthroughAdds a new guide "Integrate Prisma Postgres with Deno Deploy" and updates the site sidebar to register the guide under "Prisma Postgres for Platforms." No changes to code logic or public APIs. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Comment |
Redirect checkThis PR probably requires the following redirects to be added to static/_redirects:
|
Deploying docs with
|
Latest commit: |
8be0435
|
Status: | ✅ Deploy successful! |
Preview URL: | https://0cfb3fa4.docs-51g.pages.dev |
Branch Preview URL: | https://dc-5560-deno-deploy-integrat.docs-51g.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (2)
content/800-guides/400-deno-integration.mdx (2)
58-61
: Consider expanding GitHub setup instructions.The guide mentions pushing to GitHub but doesn't provide detailed commands. Users unfamiliar with Git might benefit from explicit instructions like:
git init git add . git commit -m "Initial commit" git remote add origin <your-repo-url> git push -u origin main
82-86
: Consider adding a security reminder.While the guide instructs users to add the connection string to
.env
, it would be helpful to explicitly remind them to add.env
to their.gitignore
file to prevent accidentally committing sensitive credentials.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
content/800-guides/400-deno-integration.mdx
(1 hunks)sidebars.ts
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: runner / linkspector
- GitHub Check: Check internal links
- GitHub Check: Lost Pixel
🔇 Additional comments (3)
sidebars.ts (1)
476-476
: LGTM!The sidebar entry is correctly placed under "Prisma Postgres for Platforms" and follows the established naming convention. The path matches the new guide document.
content/800-guides/400-deno-integration.mdx (2)
124-152
: LGTM! Schema configuration is correct for Deno.The Prisma schema correctly configures:
provider = "prisma-client"
instead ofprisma-client-js
runtime = "deno"
for Deno compatibility- A well-structured
Log
model with proper typesThese changes are essential for Prisma to work correctly in the Deno environment.
227-248
: LGTM! Deployment instructions are clear and correct.The build command properly includes Prisma Client generation with the necessary permissions, and the deployment workflow is well-explained.
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 86.8%, saving 365.7 KB.
|
Summary by CodeRabbit