Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(turso): uncomment orThrow methods #4914

Merged
merged 1 commit into from
May 7, 2024
Merged

test(turso): uncomment orThrow methods #4914

merged 1 commit into from
May 7, 2024

Conversation

Jolg42
Copy link
Contributor

@Jolg42 Jolg42 commented May 7, 2024 •
edited
Loading

Closes https://github.com/prisma/team-orm/issues/663

It turns out that it just works.

@Jolg42 Jolg42 marked this pull request as ready for review May 7, 2024 09:31
@Jolg42 Jolg42 requested review from janpio, SevInf and jkomyno as code owners May 7, 2024 09:31
@janpio janpio requested a review from millsp May 7, 2024 09:42
@Jolg42 Jolg42 added this to the 5.14.0 milestone May 7, 2024
@Jolg42 Jolg42 mentioned this pull request May 7, 2024
Open
@Jolg42
Copy link
Contributor Author

Jolg42 commented May 7, 2024

Note from @janpio we could have a test where orThrow throws, I created #4918

@Jolg42 Jolg42 merged commit 1378060 into dev May 7, 2024
56 of 57 checks passed
@Jolg42 Jolg42 deleted the joel/turso-orThrow branch May 7, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millsp millsp millsp approved these changes

@janpio janpio Awaiting requested review from janpio

@SevInf SevInf Awaiting requested review from SevInf

@jkomyno jkomyno Awaiting requested review from jkomyno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Jolg42 @millsp