Use latest Rust in Alpine 3.15 image #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes build errors in prisma-engines due to Rust 1.65 being too old.
aqrln
commented
Aug 14, 2023
| RUN cd openssl-1.1.1s && make install | ||
| RUN cd openssl-1.1.1v && ./config --prefix=/usr/local/ssl --openssldir=/usr/local/ssl shared zlib && make -j8 | ||
|
|
||
| RUN cd openssl-1.1.1v && make install_sw install_ssldirs |
There was a problem hiding this comment.
Changed make install to make install_sw install_ssldirs to skip installing docs. This makes building the image significantly faster, installing docs takes way more time than compiling and also takes space in the image.
There was a problem hiding this comment.
Nice side effect of this PR!
jkomyno
reviewed
Aug 14, 2023
|
|
||
| RUN apk update && \ | ||
| apk add perl musl-dev build-base bash clang git protoc protobuf protobuf-dev wget linux-headers | ||
| apk add perl musl-dev build-base bash curl clang git protoc protobuf protobuf-dev linux-headers |
There was a problem hiding this comment.
+1 for using curl rather than wget 😺
There was a problem hiding this comment.
I copy-pasted the rustup command with curl so I changed the other download to use curl too 🤷
I don't have a strong preference either way.
|
Musl tests passed, we can merge. Great job @aqrln! |
jkomyno
approved these changes
Aug 14, 2023
Jolg42
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes build errors in prisma-engines due to Rust 1.65 being too old.