Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add layered architecture support #71

Merged
merged 14 commits into from
Dec 27, 2024
Merged

feat: add layered architecture support #71

merged 14 commits into from
Dec 27, 2024

Conversation

ankur-arch
Copy link
Contributor

@ankur-arch ankur-arch commented Dec 23, 2024

Copy link

vercel bot commented Dec 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuxt-prisma ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2024 6:20am

Copy link

@husayt husayt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a problem with windows support. One suggestion would be instead of path to use pathe

@ankur-arch ankur-arch mentioned this pull request Dec 26, 2024
@ankur-arch
Copy link
Contributor Author

Thanks for the suggestion @husayt, I'm using pathe instead of path.

@ankur-arch
Copy link
Contributor Author

Hey folks 👋,

This PR is ready to merge! However, there are some associated documentation updates that I’m currently working on and plan to finish by tomorrow.

In the meantime, you can test and use this release by installing: 0.0.0-experimental-2a18f01.

Thank you all for your suggestions and patience! 🙏

@husayt
Copy link

husayt commented Dec 26, 2024

@ankur-arch can you also update dependencies please? I am getting all kind of issues during install. latest nuxt is 3.15 now.

@Kuuzoo
Copy link

Kuuzoo commented Dec 26, 2024

Hey folks 👋,

This PR is ready to merge! However, there are some associated documentation updates that I’m currently working on and plan to finish by tomorrow.

In the meantime, you can test and use this release by installing: 0.0.0-experimental-2a18f01.

Thank you all for your suggestions and patience! 🙏

Hi @ankur-arch, first of all, thank you!
I've just installed the version via bun i @prisma/nuxt@0.0.0-experimental-2a18f01, and added it to my nuxt modules.

But now that I've tried to run dev, I'm stuck in a infinite loop as seen in the following picture. Sadly, I didn't find a way how to get out of there...

Maybe somebody else can give it a shot?
image

@ankur-arch
Copy link
Contributor Author

Hey there @Kuuzoo 👋 ,

Thanks!

But now that I've tried to run dev, I'm stuck in a infinite loop as seen in the following picture. Sadly, I didn't find a way how to get out of there...

I've reproduced the issue and will create a follow-up issue for it to investigate further after releasing 1.4. Currently, we're focused on prioritizing popular package managers such as npm, yarn, and pnpm. I've documented this issue to keep users aware in the docs PR here.

Maybe somebody else can give it a shot?

I always appreciate collaborators!

Also @Dobefu thanks for the immense work 🙏 and @husayt for the suggestion.

@Kuuzoo
Copy link

Kuuzoo commented Dec 27, 2024

Hey there @Kuuzoo 👋 ,

Thanks!

But now that I've tried to run dev, I'm stuck in a infinite loop as seen in the following picture. Sadly, I didn't find a way how to get out of there...

I've reproduced the issue and will create a follow-up issue for it to investigate further after releasing 1.4. Currently, we're focused on prioritizing popular package managers such as npm, yarn, and pnpm. I've documented this issue to keep users aware in the docs PR here.

Maybe somebody else can give it a shot?

I always appreciate collaborators!

Also @Dobefu thanks for the immense work 🙏 and @husayt for the suggestion.

Does this issue only happen with bun? or is this with all other package managers like pnpm, yarn, deno, etc?
Because you've wrote that this issue seems to strictly appear with bun? 🤔

"The module is designed to support popular package managers such as npm, Yarn, and pnpm. However, as of v1.4, it does not fully support Bun due to an issue where the installation process loops indefinitely."

@ankur-arch
Copy link
Contributor Author

ankur-arch commented Dec 27, 2024

Does this issue only happen with bun? or is this with all other package managers like pnpm, yarn

Hey @Kuuzoo ,

I've tested the code with npm, Yarn, pnpm, and Bun, but I haven't tested it with Deno yet. Since the issue doesn't occur with the supported package managers, I believe this PR is ready to be closed.

That said, I can update the documentation title to something more descriptive, like 'Supported Package Managers,' and include Deno there as well if needed.

@ankur-arch ankur-arch merged commit 6e616be into main Dec 27, 2024
3 checks passed
Copy link

🎉 This PR is included in version 0.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Kuuzoo
Copy link

Kuuzoo commented Dec 27, 2024

Does this issue only happen with bun? or is this with all other package managers like pnpm, yarn

Hey @Kuuzoo ,

I've tested the code with npm, Yarn, pnpm, and Bun, but I haven't tested it with Deno yet. Since the issue doesn't occur with the supported package managers, I believe this PR is ready to be closed.

That said, I can update the documentation title to something more descriptive, like 'Supported Package Managers,' and include Deno there as well if needed.

Maybe bun has some seperate order with calling postinstall? Maybe they are trying to call it before 100% finishing the installation of the package, which will cause it to be stuck in a loop.

I've also did a little bit of refactoring and got rid of the own functions to check if prisma is installed, because you now have nypm so we can actually make use of it 🙃
Kuuzoo@4baa33f

Should I open a PR about this?

@ankur-arch
Copy link
Contributor Author

Maybe bun has some seperate order with calling postinstall? Maybe they are trying to call it before 100% finishing the installation of the package, which will cause it to be stuck in a loop.

I've also did a little bit of refactoring and got rid of the own functions to check if prisma is installed, because you now have nypm so we can actually make use of it 🙃
Kuuzoo@4baa33f

Should I open a PR about this?

@Kuuzoo Please do! Let's carry on the conversation there.

@Kuuzoo
Copy link

Kuuzoo commented Dec 28, 2024

Maybe bun has some seperate order with calling postinstall? Maybe they are trying to call it before 100% finishing the installation of the package, which will cause it to be stuck in a loop.

I've also did a little bit of refactoring and got rid of the own functions to check if prisma is installed, because you now have nypm so we can actually make use of it 🙃
Kuuzoo@4baa33f

Should I open a PR about this?

@Kuuzoo Please do! Let's carry on the conversation there.

Should be open now 👍
#73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants