-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add layered architecture support #71
Conversation
ankur-arch
commented
Dec 23, 2024
•
edited
Loading
edited
- Adds layered architecture(Package manager cannot get resolved when using Nuxt Layers #29)
- Closes Incompatibility with Prisma ORM 6 #67
- Closes Package manager cannot get resolved when using Nuxt Layers #29
- Closes Usage with a layer based architecture #16
…ckage-manager-cannot-get-resolved
feat: add support for layered architecture
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have a problem with windows support. One suggestion would be instead of path to use pathe
Thanks for the suggestion @husayt, I'm using |
Hey folks 👋, This PR is ready to merge! However, there are some associated documentation updates that I’m currently working on and plan to finish by tomorrow. In the meantime, you can test and use this release by installing: Thank you all for your suggestions and patience! 🙏 |
@ankur-arch can you also update dependencies please? I am getting all kind of issues during install. latest nuxt is 3.15 now. |
Hi @ankur-arch, first of all, thank you! But now that I've tried to run dev, I'm stuck in a infinite loop as seen in the following picture. Sadly, I didn't find a way how to get out of there... |
Hey there @Kuuzoo 👋 , Thanks!
I've reproduced the issue and will create a follow-up issue for it to investigate further after releasing 1.4. Currently, we're focused on prioritizing popular package managers such as npm, yarn, and pnpm. I've documented this issue to keep users aware in the docs PR here.
I always appreciate collaborators! Also @Dobefu thanks for the immense work 🙏 and @husayt for the suggestion. |
Does this issue only happen with bun? or is this with all other package managers like pnpm, yarn, deno, etc? "The module is designed to support popular package managers such as npm, Yarn, and pnpm. However, as of |
Hey @Kuuzoo , I've tested the code with npm, Yarn, pnpm, and Bun, but I haven't tested it with Deno yet. Since the issue doesn't occur with the supported package managers, I believe this PR is ready to be closed. That said, I can update the documentation title to something more descriptive, like 'Supported Package Managers,' and include Deno there as well if needed. |
🎉 This PR is included in version 0.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Maybe bun has some seperate order with calling postinstall? Maybe they are trying to call it before 100% finishing the installation of the package, which will cause it to be stuck in a loop. I've also did a little bit of refactoring and got rid of the own functions to check if prisma is installed, because you now have nypm so we can actually make use of it 🙃 Should I open a PR about this? |
@Kuuzoo Please do! Let's carry on the conversation there. |
Should be open now 👍 |