Skip to content

Commit

Permalink
query-engine-wasm: Fix build & ensure it stays fixed (#4488)
Browse files Browse the repository at this point in the history
* query-engine-wasm: Fix build & ensure it stays fixed

Current version in main does not compile to wasm correctly. This PR
fixes the error and adds CI check to ensure it compiles before it is
merged.

* Add name to the job

* Update .github/workflows/qe-wasm-check.yml

Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>

---------

Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
  • Loading branch information
SevInf and Jolg42 authored Nov 21, 2023
1 parent ba74bdf commit 63a4fd9
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 1 deletion.
27 changes: 27 additions & 0 deletions .github/workflows/qe-wasm-check.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: WASM engine compile check
on:
push:
branches:
- main
pull_request:
paths-ignore:
- '.github/**'
- '!.github/workflows/qe-wasm-check.yml'
- '.buildkite/**'
- '*.md'
- 'LICENSE'
- 'CODEOWNERS'
- 'renovate.json'

jobs:
build:
name: 'Compilation check for query-engine-wasm'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
- name: Install wasm-pack
run: cargo install wasm-pack
- name: Build wasm query engine
run: ./build.sh
working-directory: ./query-engine/query-engine-wasm
2 changes: 1 addition & 1 deletion query-engine/request-handlers/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ edition = "2021"

[dependencies]
prisma-models = { path = "../prisma-models" }
query-core = { path = "../core", features = ["metrics"] }
query-core = { path = "../core" }
user-facing-errors = { path = "../../libs/user-facing-errors" }
quaint = { path = "../../quaint" }
psl.workspace = true
Expand Down

0 comments on commit 63a4fd9

Please sign in to comment.