Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rustix to 0.36.13 #3962

Merged
merged 1 commit into from
May 8, 2023
Merged

Update rustix to 0.36.13 #3962

merged 1 commit into from
May 8, 2023

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented May 8, 2023

Update rustix with cargo update -p rustix.

This should work around the ICE that happens when running cargo doc on CI: https://github.com/prisma/prisma-engines/actions/runs/4915235114/jobs/8777494487.

The ICE is already fixed in beta and nightly but not in stable yet (rust-lang/rust#109424). Newer versions of rustix than we have don't trigger the bug because it was worked around in bytecodealliance/rustix#627.

Update rustix with `cargo update -p rustix`.

This should work around the ICE that happens when running `cargo doc`
on CI: https://github.com/prisma/prisma-engines/actions/runs/4915235114/jobs/8777494487.

The ICE is already fixed in beta and nightly but not in stable
yet (rust-lang/rust#109424). Newer versions
of rustix than we have don't trigger the bug because it was worked
around in bytecodealliance/rustix#627.
@aqrln aqrln requested a review from tomhoule May 8, 2023 13:45
@aqrln aqrln added this to the 4.14.0 milestone May 8, 2023
@codspeed-hq
Copy link

codspeed-hq bot commented May 8, 2023

CodSpeed Performance Report

Merging #3962 fix/update-rustix (f252dc4) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 11 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@aqrln aqrln merged commit d9a4c59 into main May 8, 2023
@aqrln aqrln deleted the fix/update-rustix branch May 8, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants