sql-schema-connector: remove BINARY from queries

[Jolg42]

From #4130

Internal Slack

Context: vitessio/vitess#13764 (comment)

Docs: https://dev.mysql.com/doc/refman/8.0/en/cast-functions.html

The BINARY operator converts the expression to a binary string (a string that has the binary character set and binary collation). A common use for BINARY is to force a character string comparison to be done byte by byte using numeric byte values rather than character by character. The BINARY operator also causes trailing spaces in comparisons to be significant.

Deprecation note:

The BINARY operator is deprecated as of MySQL 8.0.27, and you should expect its removal in a future version of MySQL. Use CAST(... AS BINARY) instead.

So one question to resolve before we can merge this is to know if the behavior mentioned in the docs is required here for us.

[codspeed-hq]

CodSpeed Performance Report

Merging #4131 will improve performances by 5.01%

_{Comparing joel/remove-BINARY (aec6ac6) with main (9fe3fe4)}

Summary

🔥 1 improvements
✅ 10 untouched benchmarks

Benchmarks breakdown

	Benchmark	main	joel/remove-BINARY	Change
🔥	large_read	7.7 ms	7.3 ms	+5.01%

[Jolg42]

Note that some tests are failing, I didn't check why yet.

[tomhoule]

The reason for the casts to BINARY is sort order (so the ordering matches between the database and application code), so we should still cast, but the non-deprecated way.

[Jolg42]

Closing this for now, I persisted the deprecation into a new issue #4146