Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Show 3 digits in size reports, strip gzip timestamps #4565

Merged
merged 2 commits into from
Dec 14, 2023
Merged

ci: Show 3 digits in size reports, strip gzip timestamps #4565

merged 2 commits into from
Dec 14, 2023

Conversation

SevInf
Copy link
Contributor

@SevInf SevInf commented Dec 14, 2023 •
edited
Loading

  • More digits in the table make it easier to see smaller changes
  • Stripping timestamp and file name from gzip should avoid random 1-3 bytes differences for gzip

@SevInf
ci: Show 3 digits in size reports
66aa1aa 
Should make it easier to see smaller changes
@SevInf SevInf added this to the 5.8.0 milestone Dec 14, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 14, 2023 •
edited
Loading

WASM Size

Engine This PR Base branch Diff
WASM 3.192MiB 3.192MiB 0.000B
WASM (gzip) 1.202MiB 1.202MiB 0.000B

@SevInf SevInf marked this pull request as ready for review December 14, 2023 10:05
@SevInf SevInf requested a review from a team as a code owner December 14, 2023 10:05
@SevInf SevInf requested review from miguelff, Weakky and jkomyno and removed request for a team and Weakky December 14, 2023 10:05
@SevInf SevInf changed the title ci: Show 3 digits in size reports ci: Show 3 digits in size reports, strip gzip timestamps Dec 14, 2023
@miguelff miguelff merged commit fb2743a into main Dec 14, 2023
6 checks passed
@miguelff miguelff deleted the more-size-digit branch December 14, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelff miguelff Awaiting requested review from miguelff miguelff is a code owner automatically assigned from prisma/orm-rust

@jkomyno jkomyno Awaiting requested review from jkomyno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SevInf @miguelff