Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: json protocol should raise rich error on unknown nested field #4921

Merged
merged 1 commit into from
Jun 14, 2024
Merged

fix: json protocol should raise rich error on unknown nested field #4921

merged 1 commit into from
Jun 14, 2024

Conversation

Weakky
Copy link
Contributor

@Weakky Weakky commented Jun 14, 2024

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 14, 2024

CodSpeed Performance Report

Merging #4921 will not alter performance

Comparing fix/json-nested-field-rich-error (9baef78) with main (9959b17)

Summary

✅ 11 untouched benchmarks

@Weakky Weakky added this to the 5.16.0 milestone Jun 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.043MiB 2.044MiB -290.000B
Postgres (gzip) 814.453KiB 814.499KiB -47.000B
Mysql 2.013MiB 2.014MiB -290.000B
Mysql (gzip) 801.130KiB 801.028KiB 105.000B
Sqlite 1.914MiB 1.915MiB -290.000B
Sqlite (gzip) 763.381KiB 763.412KiB -31.000B

@Weakky Weakky marked this pull request as ready for review June 14, 2024 11:57
@Weakky Weakky requested a review from a team as a code owner June 14, 2024 11:57
@Weakky Weakky requested review from laplab and removed request for a team June 14, 2024 11:57
@SevInf SevInf merged commit e974ca8 into main Jun 14, 2024
182 checks passed
@SevInf SevInf deleted the fix/json-nested-field-rich-error branch June 14, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevInf SevInf SevInf approved these changes

@laplab laplab Awaiting requested review from laplab laplab is a code owner automatically assigned from prisma/orm-rust

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Weakky @SevInf