Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query-engine): fix D1 tracing bug on comments #4931

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Jun 20, 2024

This PR fixes https://github.com/prisma/team-orm/issues/880 and reverts prisma/quaint#395.

This is fine, because the problem that prisma/quaint#395 fixed is no longer problem in the SQLite version shipped with the native Rust SQLite driver (SQLite 3.41.2).

See Slack thread.

Co-author: @SevInf.

@jkomyno jkomyno self-assigned this Jun 20, 2024
@jkomyno jkomyno added this to the 5.16.0 milestone Jun 20, 2024
Copy link
Contributor

github-actions bot commented Jun 20, 2024

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.043MiB 2.043MiB 0.000B
Postgres (gzip) 814.452KiB 814.447KiB 5.000B
Mysql 2.013MiB 2.013MiB 0.000B
Mysql (gzip) 801.129KiB 801.126KiB 3.000B
Sqlite 1.914MiB 1.914MiB 9.000B
Sqlite (gzip) 763.379KiB 763.377KiB 2.000B

Copy link

codspeed-hq bot commented Jun 20, 2024

CodSpeed Performance Report

Merging #4931 will not alter performance

Comparing fix/d1-tracing-comment-bug (ae2ec77) with main (bd07760)

Summary

✅ 11 untouched benchmarks

@jkomyno jkomyno marked this pull request as ready for review June 20, 2024 14:52
@jkomyno jkomyno requested a review from a team as a code owner June 20, 2024 14:52
@jkomyno jkomyno requested review from laplab and removed request for a team June 20, 2024 14:52
@jkomyno jkomyno merged commit d56fe2e into main Jun 24, 2024
208 checks passed
@jkomyno jkomyno deleted the fix/d1-tracing-comment-bug branch June 24, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants