Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pest): be inclusive of unicode characters in identifiers to introduce better warnings #4959

Merged
merged 8 commits into from
Nov 19, 2024
Merged

fix(pest): be inclusive of unicode characters in identifiers to introduce better warnings #4959

merged 8 commits into from
Nov 19, 2024
+63 −1

Conversation

Druue
Copy link
Contributor

@Druue Druue commented Jul 18, 2024 •
edited
Loading

@Druue Druue added this to the 5.18.0 milestone Jul 18, 2024
@Druue Druue requested a review from a team as a code owner July 18, 2024 11:11
@Druue Druue requested review from jkomyno and removed request for a team July 18, 2024 11:11
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 18, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4959 will degrade performances by 8.51%

Comparing fix/handle-non-ascii-field-idents (ef43837) with main (378004b)

Summary

❌ 3 regressions
✅ 8 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix/handle-non-ascii-field-idents Change
❌ validate (large) 64.1 ms 70 ms -8.51%
❌ validate (medium) 14.1 ms 15.2 ms -7.44%
❌ validate (small) 2.1 ms 2.2 ms -7.31%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024 •
edited
Loading

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.038MiB 2.032MiB 5.567KiB
Postgres (gzip) 818.842KiB 816.877KiB 1.965KiB
Mysql 2.001MiB 1.995MiB 5.567KiB
Mysql (gzip) 804.596KiB 802.624KiB 1.973KiB
Sqlite 1.900MiB 1.895MiB 5.558KiB
Sqlite (gzip) 765.016KiB 763.271KiB 1.746KiB

@Druue Druue marked this pull request as draft July 18, 2024 11:47
@Druue Druue changed the title fix(pest): be inclusive of unicode characters in identifiers fix(pest): be inclusive of unicode characters in identifiers to introduce better warnings Jul 19, 2024
@jkomyno jkomyno marked this pull request as ready for review November 15, 2024 17:12
@jkomyno jkomyno modified the milestones: 5.18.0, 6.0.0 Nov 15, 2024
@jkomyno jkomyno merged commit 5b155e0 into main Nov 19, 2024
366 of 367 checks passed
@jkomyno jkomyno deleted the fix/handle-non-ascii-field-idents branch November 19, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkomyno jkomyno jkomyno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Druue @jkomyno