Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Restore compilation check on PR #4963

Merged
merged 7 commits into from
Jul 23, 2024
Merged

ci: Restore compilation check on PR #4963

merged 7 commits into from
Jul 23, 2024

Conversation

SevInf
Copy link
Contributor

@SevInf SevInf commented Jul 22, 2024

Restore macos/windows compilation check on pull requests and add react
native as well.

Restore macos/windows compilation check on pull requests and add react
native as well.
@SevInf SevInf requested a review from a team as a code owner July 22, 2024 15:29
@SevInf SevInf requested review from Weakky and removed request for a team July 22, 2024 15:29
@SevInf SevInf added this to the 5.18.0 milestone Jul 22, 2024
Copy link

codspeed-hq bot commented Jul 22, 2024

CodSpeed Performance Report

Merging #4963 will not alter performance

Comparing feat/compile-check (aec49f1) with feat/compile-check (e8b177c)

Summary

✅ 11 untouched benchmarks

Copy link
Contributor

github-actions bot commented Jul 22, 2024

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.057MiB 2.056MiB 1.236KiB
Postgres (gzip) 820.454KiB 820.650KiB -201.000B
Mysql 2.027MiB 2.025MiB 2.593KiB
Mysql (gzip) 808.037KiB 808.056KiB -20.000B
Sqlite 1.919MiB 1.918MiB 1.023KiB
Sqlite (gzip) 766.279KiB 765.961KiB 325.000B

schema-engine/tmp Outdated Show resolved Hide resolved
Copy link
Contributor

@Weakky Weakky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@SevInf SevInf merged commit a6977e5 into main Jul 23, 2024
24 checks passed
@SevInf SevInf deleted the feat/compile-check branch July 23, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants