chore: update Rust to 1.80.1 #4972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `cfg` attribute for non-existent `bigdecimal` feature in quaint test. Besides fixing a compiler warning, this also enables this test, which was previously skipped.
WASM Query Engine file Size
|
jkomyno
approved these changes
Aug 7, 2024
|
Clippy is still failing due to unused |
|
@jkomyno yeah I saw that, I'll be able to take a look tonight |
CodSpeed Performance ReportMerging #4972 will not alter performanceComparing Summary
|
aqrln
commented
Aug 9, 2024
| @@ -142,9 +142,9 @@ pub fn list_migrations(database_filename: &Path) -> Result<Vec<MigrationRecord>> | |||
| let failed_at: Option<Timestamp> = row.get(4).unwrap(); | |||
|
|
|||
| entries.push(MigrationRecord { | |||
| id, | |||
| _id: id, | |||
There was a problem hiding this comment.
Left these two for now to be safe in case they were intentionally left for future but they are currently unused and can be removed from both the struct and the SQL query.
jkomyno
approved these changes
Aug 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timedependency to fix compilation errorcfgfor non-existentbigdecimalfeature and thus enable an unintentionally disabled test