feat: add case-insensitive support in advanced Json filtering

[lubosmato]

The PR adds case field into Json filtering to allow case-insensitive text filtering with Json fields.

E.g.:

prisma.article.findMany({
  where: {
    title: {
      path: ["en"],
      string_contains: searchText,
      mode: "insensitive",
    },
  }
})

Fixes prisma/prisma#7390

[CLAassistant]

All committers have signed the CLA.

[macrozone]

that would be some awesome to have

[jkomyno]

Thanks for this PR! I've left a couple of comments for further iterations and better compatibility with the other database providers.

[jkomyno]

The ILIKE comparison operator is only available on PostgreSQL and CockroachDB.
Since Prisma supports several other database providers (like SQLite, MySQL, MongoDB), we should steer away from using raw operators directly.

Usually, we rely on connector-specific primitives wrapped in a common abstraction (quaint::connector::queryable::Queryable).

But in this case, the way forward is probably to change the implementations of the quaint::visitor::Visitor trait to align visit_json_extract and similar methods to prisma/prisma#7390 (comment), lowering the case of both compared values when mode: 'insensitive' is applied.

[lubosmato]

Nice catch, thank you!

[jkomyno]

Can we choose another name for the currently called "query mode"? How about case: 'sensitive' | 'insensitive', where case: 'sensitive' is the default option?

[lubosmato]

After adding case enum, it feels a bit incosistent with the rest of where api. Especially when looking into cases like:

prisma.recipe.findMany({
  where: {
    allergens: {
      not: { contains: "peanuts" },
      mode: "insensitive", // <-- mode
    },
    title: {
      path: [locale],
      string_contains: filter.search,
      case: "insensitive", // <-- case
    },
  },
})

[jkomyno]

Hi @lubosmato, after talking with a colleague, and observing this output, I stand corrected. I didn't realise QueryMode was an already existing enum in out codebase (

prisma-engines/query-engine/query-structure/src/filter/scalar/mod.rs

Line 29 in 119ee81

pub enum QueryMode {

). So, let's stick with mode: 'default' | 'insensitive':)

[lubosmato]

Hi @jkomyno, thank you for reply. I reverted the commit with case enum.

[lubosmato]

@jkomyno thank you for review, would you find time for another round?

Also I would like to ask you if you could point me to the right direction. I tried to hook up prisma client with locally built bins/libs to test this feature with prisma generate on an existing project but generated files have no mention of newly added changes (e.g. case field is missing). In dmmf output I can see newly added field case.

I tried to set env vars PRISMA_QUERY_ENGINE_* and PRISMA_SCHEMA_ENGINE_BINARY and run prisma generate. prisma version is showing that correct libs/bins are used but resulting generated types for prisma-client-js generator are not affected.

What needs to be done in order to make prisma-client-js generator generate types with locally built prisma-engines?

[lubosmato]

Hi @jkomyno, what are the next steps/is there anything else that needs to be done from my end?

[codspeed-hq]

CodSpeed Performance Report

Merging #4977 will not alter performance

_{Comparing lubosmato:main (860c583) with main (f2561ec)}

Summary

✅ 11 untouched benchmarks

[aqrln]

Also I would like to ask you if you could point me to the right direction. I tried to hook up prisma client with locally built bins/libs to test this feature with prisma generate on an existing project but generated files have no mention of newly added changes (e.g. case field is missing). In dmmf output I can see newly added field case.

I tried to set env vars PRISMA_QUERY_ENGINE_* and PRISMA_SCHEMA_ENGINE_BINARY and run prisma generate. prisma version is showing that correct libs/bins are used but resulting generated types for prisma-client-js generator are not affected.

What needs to be done in order to make prisma-client-js generator generate types with locally built prisma-engines?

This is slightly annoying to do, sorry for that. Prisma CLI (and generator) doesn't use the query engine to get the DMMF, it uses the WASM module (published as @prisma/prisma-schema-wasm on npm). You can build it locally by running make build-schema-wasm in the engines directory, the built package will be in target/prisma-schema-wasm. Unfortunately there's no convenient way to make CLI use it; what I do is just manually edit https://github.com/prisma/prisma/blob/7955bca6c4e343e452f9138547d42d952ad0c54d/packages/internals/src/wasm.ts#L1 to import this package from the engines directory in the local filesystem and rebuild Prisma.