Fix encoding of zero-length values for large varlen columns #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Oh my god this fixed my issues, thanks a LOT! 🥰 |
|
Hey @descawed, Apologies for the long delay in getting this PR reviewed. We're merging this now, thank you for the contribution 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encoding a value for a large varlen column (e.g.
varchar(max),nvarchar(max),varbinary(max)), tiberius writes the value in a single chunk, then writes a zero length chunk to signal the end of the column data. However, if the value being encoded has length zero, the first chunk already ends the column data, and the server will incorrectly interpret the extra zero as part of the next column's data (or whatever follows this column in the buffer). This PR skips the terminating zero if the value has length zero.