-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream Merge request - we created a fork because we thought the project was dead 😺 #191
Upstream Merge request - we created a fork because we thought the project was dead 😺 #191
Conversation
* went for a full fork as mr's are not handled and we want to move forward
* needs a extra cli param `-d 'apc.enable_cli=1'`
+ added fragments * moved code to fragments
Minimal requirement of php7.4
updated PHP unit |
Hey there, first of all, @angeloashmore and I are really sorry for the delay we're taking getting back to you. We'd like to organize our process better to ensure the PHP SDK remains maintained and usable by PHP users while providing them with the support they need.
Thank you for your understanding, we're looking forward to seeing the PHP kit get back on track~ |
@lihbr Thank you for the update. I replied in the other PR already, stating my point of view. I believe we should shift the communication to just one PR so that the line of argument is easier to follow and understand. As #190 already has multiple people chatting, it might make sense to continue there. But I'm happy to switch to this PR as well |
@JeroenBoersma As feat!: support PHP 8 #190 was just merged and released as Version 5.2.0 the majority of this Pull Request became redundant and I will therefore proceed to close this matter. Nonetheless, we appreciate your time and afford and thank you for your contribution! If you would still like to contribute your Fragment changes, please open a new Issue first so we can discuss the benefits, risks and implementation of those changes. |
We love to drop our mirror with the latest fixes, so here it is a major Pull request...
What we did...