feat (ci): ensure that ci also runs on pullrequests #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@angeloashmore Can you check if this is okay with you? |
This was referenced Nov 1, 2024
|
I just quickly also removed all references to travis ci, so that we have a clean slate and there is no future confusion. The only thing I need to figure out, is how to add the GitHub Pages deployment for the PhpDoc back working with the new workflow. But that wasn't working anyway, so we can drop it for now. |
|
Hi @c0nst4ntin, the clean-up looks good! Thanks for removing Travis CI. Feel free to merge when you are ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered in PR #204 the CI seems to not work on external pull requests.
I successfully validated this in #206 and found out how to change this.