Run CI on GitHub Actions #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing until #129 merges, which should fix it. I'll rebase on |
ensures that on PR and push there's a test suite running to verify changes are passing runs against modern Ruby versions
gets on latest ver to support modern rubies
brettchalupa
force-pushed
the
ci-gh-actions
branch
from
0cd6902
to
ba718d4
Compare
|
I've rebased this branch on |
|
@alistairholt @faresd just wanted to ping you both here to see if you're interested in this addition to the gem. It's passing green and seems to be working well. 👍 |
|
Bumping again if possible to get some 👀 on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that on push to
masterand pull request that the test suite runs to ensure changes are passing. GitHub Actions are nice because it's baked into where the source code lives and doesn't require another account or service to configure.