Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Mapped slices would cause the
<TODOSliceComponent />
component to throw because of a different interface used by mapped slices (slice type being top level instead of nested under theslice
property).This standardizes the props given to
<TODOSliceComponent />
so everything keeps working smoothly based on our Svelte implementation: https://github.com/prismicio/prismic-svelte/blob/master/src/SliceZone/SliceZone.svelte#L118-L128I first explored adapting the
<TODOSliceComponent />
to support different interfaces instead, but it resulted in messier code in my opinion:prismic-vue/src/components/SliceZone.ts
Lines 263 to 280 in 95d5771
Checklist: