-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: v5 #74
Open
lihbr
wants to merge
33
commits into
master
Choose a base branch
from
v5
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angeloashmore
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, although my Vue knowledge is limited. I left a few small suggestions.
messages/html-serialization-is-deprecated-with-prismic-rich-text.md
Outdated
Show resolved
Hide resolved
messages/html-serialization-is-deprecated-with-prismic-rich-text.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Breaking changes:
isomorphic-unfetch
fallback whenglobalThis.fetch
is not availablehtmlSerializer
option, userichTextSerializer
insteadimageComponent
component optionlinkBlankTargetRelAttribute
component option<SliceZone />
resolver
prop<PrismicImage />
imageComponent
propusePrismicImage
composable<PrismicLink />
target
propblankTargetRelAttribute
propnoopener noreferrer
tonorefferer
target="_blank"
ones)field
prop, use the new dedicateddocument
prop to render documents as linksusePrismicLink
composable<PrismicText />
usePrismicText
composable<PrismicRichText />
htmlSerializer
prop, useserializer
insteadusePrismicRichText
composableserializer
propDefineComponentSliceComponentProps
type is not exported anymoreFeatures:
linkRel
option as a replacement ofblankTargetRelAttribute
<PrismicImage />
alt
andfallbackAlt
propssrcSet
by default<PrismicLink />
rel
prop now supports a function value to resolve the desired rel attribute value<PrismicRichText />
Documentation:
CONTRIBUTING.md
guideChecklist: