Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update halo2curves to v0.4.0 #234

Closed

Conversation

jonathanpwang
Copy link

No description provided.

@jonathanpwang
Copy link
Author

edit: it seems this requires halo2_proofs refactors around E::Fr instead of E::Scalar for E: Engine

@mratsim
Copy link

mratsim commented Dec 7, 2023

I'm a bit lost in the versioning situation with:

If I understood correctly, going to 0.4 shouldn't trigger again #63 right?

@CPerezz
Copy link
Member

CPerezz commented Dec 7, 2023

Yes, versioning is madness.. Mainly because people said that we should respect the GH tags which weren't matching the crates.io versioning...

And it all turned out to be a mess.

As for your question @mratsim , no, it should not. But maybe worth double-checking! Will do it within the next days!

@CPerezz
Copy link
Member

CPerezz commented Dec 29, 2023

Closing as duplicated of #242

@CPerezz CPerezz closed this Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants