Update & clean benchmarks #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidnevadoc
force-pushed
the
nev@benchmarks
branch
from
632afad to
fff19b5
Compare
adria0
reviewed
Jun 20, 2024
| @@ -38,8 +42,9 @@ fn generate_data(k: u32) -> Vec<Scalar> { | |||
|
|
|||
| fn fft(c: &mut Criterion) { | |||
There was a problem hiding this comment.
AFAIS best_fft can use different algorithms, depending on log_n <= log_threads.
Asking myself if it's a good performance test if we do not control the number of threads here.
There was a problem hiding this comment.
Hmmm 🤔 I'd say it only makes sense to compare results when the number of threads used is the same (and therefore the same algorithm is used). It is true that this can show up as a weird trend when comparing the performance of the fft at different sizes in the same system.
adria0
reviewed
Jun 20, 2024
adria0
reviewed
Jun 20, 2024
guorong009
reviewed
Jun 21, 2024
davidnevadoc
force-pushed
the
nev@benchmarks
branch
from
c84dc2e to
0d707d9
Compare
|
The PR looks good to me! @davidnevadoc |
adria0
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a general cleanup of the benchmarks.
Changes
bn256_field->field_arithgroup->curveless_thanbenchmark.pairingbenchmark.bn256in all benchmarks. ( All benchmarks are generic so they can be easily run for any other field or curve).