-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor field tests #166
Merged
Merged
Refactor field tests #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidnevadoc
force-pushed
the
nev@refactor-test
branch
from
June 25, 2024 18:28
1eb857a
to
fad57d7
Compare
davidnevadoc
force-pushed
the
nev@refactor-test
branch
from
July 22, 2024 18:08
fad57d7
to
1c0843f
Compare
davidnevadoc
force-pushed
the
nev@refactor-test
branch
from
September 12, 2024 08:41
1c0843f
to
8f06428
Compare
adria0
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some comments and clarifications
Co-authored-by: adria0.eth <5526331+adria0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the field tests to achieve 2 goals:
Changes
PrimeField
constants for quadratic-extension fields in BN and BLS curves.Future work
Do the same for curves.