Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: general cleanup, variables/events/functions renaming #1426

Merged
merged 1 commit into from
May 11, 2024

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented May 6, 2024

Description

Ensure functions/events/variables/test descriptions reflect the latest code changes optimize contracts and remove unnecessary logic

  • Remove ownable from MACI - anyone can deploy a poll now and they all are independent
  • Remove ownable from Poll - anyone can technically merge the message tree if they are willing to pay the gas for it
  • Remove transferOwnership in MpFactory and TallyFactory - directly use caller from Maci.deployPoll
  • Rename functions/events to reflect removal of state acc queue
  • Remove dead code
  • Add tests to ensure above changes do not affect logic

Confirmation

Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview May 10, 2024 1:48pm

contracts/contracts/MessageProcessor.sol Fixed Show fixed Hide fixed
contracts/contracts/Tally.sol Fixed Show fixed Hide fixed
contracts/contracts/Poll.sol Dismissed Show dismissed Hide dismissed
contracts/contracts/PollFactory.sol Dismissed Show dismissed Hide dismissed
@ctrlc03 ctrlc03 force-pushed the refactor/contracts-optimizations-cleanup branch from e2f5646 to 2720492 Compare May 6, 2024 09:04
@ctrlc03 ctrlc03 force-pushed the refactor/contracts-optimizations-cleanup branch from 2720492 to 6003876 Compare May 7, 2024 12:27
@ctrlc03 ctrlc03 force-pushed the refactor/contracts-optimizations-cleanup branch from 6003876 to b22e6ac Compare May 7, 2024 14:28
@ctrlc03 ctrlc03 requested a review from kittybest May 7, 2024 16:44
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks, just one question but everything looks good

contracts/contracts/MACI.sol Show resolved Hide resolved
contracts/contracts/Poll.sol Show resolved Hide resolved
@ctrlc03 ctrlc03 force-pushed the refactor/contracts-optimizations-cleanup branch from b22e6ac to f9f5d46 Compare May 8, 2024 14:42
@ctrlc03 ctrlc03 force-pushed the refactor/contracts-optimizations-cleanup branch from f9f5d46 to be2f725 Compare May 9, 2024 14:03
@ctrlc03 ctrlc03 force-pushed the refactor/contracts-optimizations-cleanup branch from be2f725 to 6485730 Compare May 10, 2024 11:00
@ctrlc03 ctrlc03 requested a review from 0xmad May 10, 2024 11:49
ensure functions/events/variables/test descriptions reflect the latest code changes
optimize contracts and remove unnecessary logic
@ctrlc03 ctrlc03 force-pushed the refactor/contracts-optimizations-cleanup branch from 6485730 to b5f5015 Compare May 10, 2024 13:42
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks!

@ctrlc03 ctrlc03 merged commit 0948471 into dev May 11, 2024
20 checks passed
@ctrlc03 ctrlc03 deleted the refactor/contracts-optimizations-cleanup branch May 11, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants