Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove duplicate words #1448

Merged
merged 1 commit into from
May 13, 2024
Merged

chore: remove duplicate words #1448

merged 1 commit into from
May 13, 2024

Conversation

goofylfg
Copy link
Contributor

@goofylfg goofylfg commented May 9, 2024 •
edited
Loading

Description

remove duplicate words in commet

Additional Notes

Related issue(s)

Confirmation

@vercel Vercel
Copy link

vercel bot commented May 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview May 13, 2024 7:09pm

kittybest
kittybest approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ctrlc03
ctrlc03 requested changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left one comment

cli/ts/utils/storage.ts Outdated Show resolved Hide resolved
@ctrlc03
Copy link
Collaborator

ctrlc03 commented May 10, 2024

@goofylfg could you please amend you latest commit (and possibly squash both into one) and conform to commitlint conventions like you did on the first commit? so chore: [..]

@goofylfg
Copy link
Contributor Author

goofylfg commented May 10, 2024 •
edited
Loading

@goofylfg could you please amend you latest commit (and possibly squash both into one) and conform to commitlint conventions like you did on the first commit? so chore: [..]

@ctrlc03 done~

@ctrlc03
Copy link
Collaborator

ctrlc03 commented May 10, 2024

@goofylfg could you please amend you latest commit (and possibly squash both into one) and conform to commitlint conventions like you did on the first commit? so chore: [..]

@ctrlc03 done~

Awesome thanks very much :)

@ctrlc03 ctrlc03 self-requested a review May 10, 2024 07:16
@ctrlc03 ctrlc03 enabled auto-merge May 10, 2024 07:16
@goofylfg
Copy link
Contributor Author

@ctrlc03 Coordinator / build (pull_request) seems failed caused auto-merge not success

@ctrlc03
Copy link
Collaborator

ctrlc03 commented May 11, 2024

@ctrlc03 Coordinator / build (pull_request) seems failed caused auto-merge not success

there's a PR open which fixes that (basically trying to access a gh secret which PRs from fork cannot) and then we'll be able to merge yours :)

@ctrlc03 ctrlc03 merged commit f8e7ef5 into privacy-scaling-explorations:dev May 13, 2024
20 checks passed
@gitpoap-bot gitpoap-bot
Copy link

gitpoap-bot bot commented May 13, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 MACI Contributor:

GitPOAP: 2024 MACI Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittybest kittybest kittybest approved these changes

@ctrlc03 ctrlc03 ctrlc03 approved these changes

@0xmad 0xmad Awaiting requested review from 0xmad 0xmad is a code owner

@samajammin samajammin Awaiting requested review from samajammin

@crisgarner crisgarner Awaiting requested review from crisgarner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goofylfg @ctrlc03 @kittybest