test(contracts): cleanup contracts tests #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0xmad
approved these changes
Aug 1, 2024
kittybest
approved these changes
Aug 1, 2024
| @@ -34,7 +34,6 @@ describe("MACI", function test() { | |||
| let signer: Signer; | |||
|
|
|||
| const maciState = new MaciState(STATE_TREE_DEPTH); | |||
| const signUpTxOpts = { gasLimit: 400000 }; | |||
There was a problem hiding this comment.
why we need this before? (same as other gasLimit)
There was a problem hiding this comment.
I think it was there to check whether gas consumption wansn't going over 400k gas - though it seemed arbitrary, gas consumption for signup is also dependent on position of the leaf and size of tree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleanup contract tests by removing unnecessary code.
Confirmation