If it's the first batch ensure zero tally commitment #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corydickson
force-pushed
the
tally-votes-circuit-initialize
branch
from
79d6629 to
ff1040a
Compare
weijiekoh
approved these changes
Sep 3, 2021
circuits/circom/tallyVotes.circom
Outdated
| // ----------------------------------------------------------------------- | ||
| // Tally the new results | ||
| component resultCalc[numVoteOptions]; | ||
| for (var i = 0; i < numVoteOptions; i ++) { | ||
| resultCalc[i] = CalculateTotal(batchSize + 1); | ||
| resultCalc[i].nums[batchSize] <== currentResults[i]; | ||
| resultCalc[i].nums[batchSize] <== currentResults[i] * isFirstBatch.out; |
There was a problem hiding this comment.
Should we use iz.out instead?
If we multiply by isFirstBatch.out, and it's the first batch, the result is currentResults[i] * 1, but for subsequent batches, it ends up being currentResults[i] * 0.
circuits/circom/tallyVotes.circom
Outdated
| @@ -273,7 +276,7 @@ template ResultCommitmentVerifier(voteOptionTreeDepth) { | |||
| // Compute the root of the new results | |||
| component newResultsRoot = QuinCheckRoot(voteOptionTreeDepth); | |||
| for (var i = 0; i < numVoteOptions; i ++) { | |||
| newResultsRoot.leaves[i] <== newResults[i]; | |||
| newResultsRoot.leaves[i] <== newResults[i] * iz.out; | |||
There was a problem hiding this comment.
Not sure if this change should be made. Let's discuss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #269