This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
[chore] upgrade toolchain to nightly-2023-04-24 #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate-bus-mapping
adria0
reviewed
Apr 25, 2023
| @@ -28,12 +28,12 @@ pub enum Error { | |||
| /// Code not found in the CodeDB | |||
| CodeNotFound(H256), | |||
| /// Unable to figure out error at a [`GethExecStep`] | |||
| UnexpectedExecStepError(&'static str, GethExecStep), | |||
| UnexpectedExecStepError(&'static str, Box<GethExecStep>), | |||
There was a problem hiding this comment.
@lightsing, this got my attention, moving GethExecStep is related to the toolchain upgrade or for another reason?
There was a problem hiding this comment.
Yes, It's related to clippy::result_large_err
|
i noticed there is a cron job running real prove tests in .github/workflows/integration.yml. Will that be enough? |
lispc
approved these changes
Apr 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade toolchain to nightly-2023-04-24 for future compatibilities.
Issue Link
N/A
Type of change
Contents
Rationale
The toolchain currently in use is outdated and lacks stable features. Issue #1372 requires GAT, which has been stabilized since version
1.65.0. Meanwhile, the current stable Rust version is1.69.0.How Has This Been Tested?
N/A