Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user activation set to bounce tracking record #70

Merged
merged 8 commits into from
Oct 21, 2024

Conversation

amaliev
Copy link
Contributor

@amaliev amaliev commented Dec 28, 2023

Adding a set of all sites that received an interaction during this extended navigation.

This isn't necessary within this spec but will be referenced by heuristics (whatwg/compat#253) to determine which sites are eligible for the redirect heuristic. Note that the appending flow is intentionally different for the initial host and bounced hosts - in the former case we need to wait for the bounce tracking record to be created when the next navigation starts.

Closes #67


Preview | Diff

@amaliev amaliev marked this pull request as ready for review December 28, 2023 21:18
@wanderview
Copy link
Collaborator

Rather than adding this here, I think we should keep it with the heuristics spec and monkey patch the core specs. There is no strict reason to have a dependency between bounce tracking and heuristics, so we should probably avoid it.

@wanderview
Copy link
Collaborator

Rather than adding this here, I think we should keep it with the heuristics spec and monkey patch the core specs. There is no strict reason to have a dependency between bounce tracking and heuristics, so we should probably avoid it.

Thinking about this more, I think it would be fine to add here for now, but with a note that the redirect logic should be factored out into a common algorithm used by multiple features. This might be easier to do once the spec is upstreamed in the html spec, etc.

@jyasskin
Copy link
Collaborator

jyasskin commented Jan 3, 2024

You might also be able to upstream the redirect logic before the rest of the spec, if it's more-clearly useful to a spec that's already in the WHATWG.

@jyasskin jyasskin requested a review from wanderview October 21, 2024 18:20
@wanderview wanderview merged commit 25abc2b into privacycg:main Oct 21, 2024
1 check passed
github-actions bot added a commit that referenced this pull request Oct 21, 2024
SHA: 25abc2b
Reason: push, by wanderview

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normative references to discontinued specs in Navigational-Tracking Mitigations
3 participants