Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plumb activation state into parallel steps #9

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

mreichhoff
Copy link
Collaborator

TODO: activation consumption still TBD.

TODO: activation consumption still TBD.
@mreichhoff
Copy link
Collaborator Author

@domfarolino @johannhof

this should address the other feedback in the prior round, other than the goal of consuming user activation in the event that the promise is rejected (which I wanted to ask about, since the only other spec I've found with such a pattern is SAA, which I believe has the same parallelism issue).

Copy link

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you also want to consume activation in the event that you don't reject the promise? I imagine that it should be consumed regardless, no?

@mreichhoff
Copy link
Collaborator Author

I imagine that it should be consumed regardless, no?

There was a long discussion about this on the SAA side, and I believe it's still pending on some kind of temporary consumption mechanism. It might be reasonable to consume regardless, though, given the comparative ease of getting activation in this case (vs embedded content). I wonder if @johannhof has any thoughts.

Copy link
Member

@johannhof johannhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I somewhat prefer sticking to the SAA model of consumption for now. It seems like the most ergonomic model for developers and an okay compromise until we get around to figuring out the "pausing" model (which, admittedly, could take a while).

@mreichhoff
Copy link
Collaborator Author

mreichhoff commented Jan 10, 2023

that seems fair...I can leave the consumption as-is (i.e., in the rejection case only) and file an issue to revisit the concern about consuming activation in parallel steps once the temporary consumption mechanism is ready.

@mreichhoff mreichhoff merged commit 0d19e7c into privacycg:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants