-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is this an error in the spec: Chromium using storage-access-api
and not request-storage-access
for permissions policy
#104
Comments
Thanks for noticing this and sorry for the delay! Given that neither Safari nor Firefox have shipped this name I think the spec should align with the only existing implementation. There were some concerns with the |
…acycg#104) This was discussed before in privacycg#12 and there was some valid concern around the "storage-access" name based on the fact that this PP feature is more focused on "requesting" storage access, and there is no delegation mechanism like with other permissions that would make it semantically consistent. However, I think that in light of privacycg#32 and the possibility of integrating with the permissions API (giving us important functionality such as observing when storage access is granted) it seems more useful to be consistent with the (future) permission name and call both "storage-access".
To follow up here, we'll rename this in Chromium to "storage-access" and I also made that change on the spec. |
@johannhof – when is the Storage Access API shipping in Chrome? |
Hi @CetinSert, I don't have a definitive date yet but we just sent out an intent to prototype for requestStorageAccessForSite in addition to the existing I2P from Microsoft Edge. It's easiest to follow the Chromestatus entries for both efforts for timely updates. |
With the update of the SAA spec and resolution of privacycg/storage-access#104 this change updates the in-code permission policy from `storage-access-api` to `storage-access`. Bug: 1332577 Change-Id: Ic07185b8d9e9d456d20aaee418af8b495574940b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830029 Reviewed-by: Nicolas Arciniega <niarci@microsoft.com> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Brandon Maslen <brandm@microsoft.com> Reviewed-by: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/main@{#1036172}
With the update of the SAA spec and resolution of privacycg/storage-access#104 this change updates the in-code permission policy from `storage-access-api` to `storage-access`. Bug: 1332577 Change-Id: Ic07185b8d9e9d456d20aaee418af8b495574940b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830029 Reviewed-by: Nicolas Arciniega <niarci@microsoft.com> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Brandon Maslen <brandm@microsoft.com> Reviewed-by: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/main@{#1036172} NOKEYCHECK=True GitOrigin-RevId: aba6574d3e61a1648c85b30fcd34786fa89aac4d
The spec say's:
Link: https://privacycg.github.io/storage-access/#permissions-policy-integration
Yet in the Chromium source code says: the policy name is:
storage-access-api
and notrequest-storage-access
?Link: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/permissions_policy/permissions_policy_features.json5
Just wondering if there is an issue in the spec or not? Or is the code in Chromium wrong?
cc @johannhof As one of the editors and on the Chrome team.
The text was updated successfully, but these errors were encountered: