Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify spec to incorporate storage-access-for-fedcm proposal #206

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

cfredric
Copy link
Contributor

@cfredric cfredric commented Sep 6, 2024

This makes the spec changes for #204.


Preview | Diff

Copy link
Member

@johannhof johannhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall but happy to take another look since I'm asking for some bigger changes here.

storage-access.bs Outdated Show resolved Hide resolved
storage-access.bs Outdated Show resolved Hide resolved
storage-access.bs Outdated Show resolved Hide resolved
storage-access.bs Outdated Show resolved Hide resolved
@cfredric cfredric requested a review from johannhof October 11, 2024 21:44
Copy link
Member

@johannhof johannhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for cleaning up all the same site usage. Merging this given the checklist is complete but happy to make changes based on other editor's feedback later if needed.

@johannhof johannhof merged commit e239ed6 into privacycg:main Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants