chore: Remove a string copy.

Bug: N/A Change-Id: I2197bd92d81c7f378c5f79719bd41bb0fd4a0bea GitOrigin-RevId: 5b787781f46da4bc70ab2a58ad05cbcee86d2744
privacysandbox · Oct 30, 2024 · cd2b18d · cd2b18d
1 parent 3160ad4
commit cd2b18d
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/roma/byob/container/run_workers.cc b/src/roma/byob/container/run_workers.cc
@@ -199,9 +199,8 @@ std::optional<PidExecutionTokenAndPivotRootDir> ConnectSendCloneAndExec(
     PLOG(INFO) << "connect() to " << socket_name << " failed";
     return std::nullopt;
   }
-  char tmp_file[] = "/tmp/roma_app_server_XXXXXX";
-  const char* pivot_root_dir = ::mkdtemp(tmp_file);
-  if (pivot_root_dir == nullptr) {
+  std::string pivot_root_dir = "/tmp/roma_app_server_XXXXXX";
+  if (::mkdtemp(pivot_root_dir.data()) == nullptr) {
     PLOG(ERROR) << "mkdtemp()";
     return std::nullopt;
   }
@@ -239,7 +238,7 @@ std::optional<PidExecutionTokenAndPivotRootDir> ConnectSendCloneAndExec(
   return PidExecutionTokenAndPivotRootDir{
       .pid = pid,
       .execution_token = std::move(execution_token),
-      .pivot_root_dir = std::string(pivot_root_dir),
+      .pivot_root_dir = std::move(pivot_root_dir),
   };
 }
 }  // namespace