Skip to content

Commit

Permalink
chore: Rename tag for the BYOB microbenchmarking image
Browse files Browse the repository at this point in the history
Bug: b/374743046
Change-Id: Ic80aebf6d97ef9b739c8b14c05cc07e92e6b7ed8
GitOrigin-RevId: 3a535236afe775ecfc4b06b1a6e40dfdced61971
  • Loading branch information
Privacy Sandbox Team authored and copybara-github committed Oct 25, 2024
1 parent 5659082 commit dc2e739
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions docs/roma/byob/Benchmarking.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ The table below illustrates the docker flags needed to run the benchmarks.
<!-- markdownlint-disable line-length -->
| Tarball | Image Name and Tag | Supports non-Sandbox | `docker run` flags |
| --------------------------- | ------------------------------------ | -------------------- | ---------------------------------------------------------------------- |
| benchmark_nonroot_image.tar | roma-byob-benchmark-image:v1-nonroot | No | `--security-opt=seccomp=unconfined` |
| benchmark_nonroot_image.tar | privacy-sandbox/roma-byob/microbenchmarks:v1-nonroot | No | `--security-opt=seccomp=unconfined` |
| | | | `--security-opt=apparmor=unconfined` |
| | | | (optional)`--cap-add=CAP_SYS_ADMIN` only required for non-sandbox mode |
| benchmark_root_image.tar | roma-byob-benchmark-image:v1-root | Yes | Generally |
| benchmark_root_image.tar | privacy-sandbox/roma-byob/microbenchmarks:v1-root | Yes | Generally |
| | | | `--security-opt=seccomp=unconfined` |
| | | | `--security-opt=apparmor=unconfined` |
<!-- markdownlint-enable line-length -->
Expand All @@ -65,7 +65,7 @@ docker run -it \
--security-opt=apparmor=unconfined \
--cap-add=CAP_SYS_ADMIN \
--rm \
roma-byob-benchmark-image:v1-root
privacy-sandbox/roma-byob/microbenchmarks:v1-root
```

By default, the results are printed to the console. If you want to store the results in a file,
Expand All @@ -85,7 +85,7 @@ docker run \
--security-opt=apparmor=unconfined \
--cap-add=CAP_SYS_ADMIN \
--rm \
roma-byob-benchmark-image:v1-root
privacy-sandbox/roma-byob/microbenchmarks:v1-root
```

### Benchmarking on AWS EC2
Expand Down
2 changes: 1 addition & 1 deletion src/roma/byob/benchmark/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ pkg_files(
"BENCHMARK_OUT_FORMAT": "json",
},
repo_tags = [
"roma-byob-benchmark-image:v1-{flavor}{dbg}".format(
"privacy-sandbox/roma-byob/microbenchmarks:v1-{flavor}{dbg}".format(
dbg = debug_str.replace("_", "-"),
flavor = user.flavor,
),
Expand Down

0 comments on commit dc2e739

Please sign in to comment.