-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protected Audience multi-seller auction demo #241
Conversation
e0bc1ed
to
451efa1
Compare
in order to allow communications between services using FQDN hostnames within the docker bridge network
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added some comments where I believe we could improve the readability of the code. But I haven't found any major issues that should block submission.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please review my comments and let me know if that works for you
fixes multi-seller-auction demo to run both on docker & cloud run
allows communications between services based : .env -> with docker bridge network .env.dev -> with Cloud Run / Firebase hosting
Description
This PR implements Protected Audience multi-seller auction. In a multi-seller auction, the winning ad can be a header bidding auction winner, an ad server auction winner, or a Protected Audience auction winner.
To see the demo:
(This code has not been merged nor deployed to prod yet)
Related PR: #240
Instructions
To run the multi-seller demo:
?auctionType=multi
(https://privacy-sandbox-demos-shop.dev/items/1f45e?auctionType=multi)?auctionType=multi
(https://privacy-sandbox-demos-news.dev/?auctionType=multi)
Services and libraries added
Multi-slot capability
The ability to render multiple ads have been implemented via the ad server library. The publisher can define an
adUnit
that describes the ad. And each ad unit participates in one sequential auction.Example usage:
Sequence
Affected services