Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove link normalization #23

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Remove link normalization #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions docs/deploying_locally.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,6 @@ mkdir /tmp/realtime
The files that you want to server to serve should go into these directories. The server will load
their contents on startup and continue to watch them while it is running.

## Update symlinks

The usual **bazel-bin** symlink won't work by default because we compile inside Debian. This script
will correct the symlink target paths. _It must be run after each call compilation!_

```sh
./builders/tools/normalize-bazel-symlinks
```

## Start the server

```sh
Expand Down
1 change: 0 additions & 1 deletion tools/serving_data_generator/generate_load_test_data
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ mkdir -p "${DELTAS_DIR}"
BAZEL_EXTRA_ARGS=

"${TOOLS_DIR}"/bazel-debian build //tools/serving_data_generator:test_serving_data_generator
"${TOOLS_DIR}"/normalize-bazel-symlinks

declare -i nanosecond
for _ in {1..3000}
Expand Down
2 changes: 0 additions & 2 deletions tools/udf/sample_word2vec/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ Set up the data:

```sh
mkdir /tmp/deltas
./builders/tools/normalize-bazel-symlinks
cp $(builders/tools/bazel-debian aquery 'tools/udf/sample_word2vec:udf_delta' |
sed -n 's/Outputs: \[\(.*\)\]/\1/p' |
xargs dirname)/DELTA* /tmp/deltas
Expand All @@ -76,7 +75,6 @@ Build the local server:
Run the local server:

```sh
./builders/tools/normalize-bazel-symlinks
GLOG_alsologtostderr=1 \
./bazel-bin/components/data_server/server/server \
--delta_directory=/tmp/deltas \
Expand Down